Hello

I have been selected to do a routing directorate “early” review of this draft.
https://datatracker.ietf.org/doc/html/draft-ietf-teas-yang-l3-te-topo-16 

The routing directorate will, on request from the working group chair, perform an “early” review of a draft before it is submitted for publication to the IESG. The early review can be performed at any time during the draft’s lifetime as a working group document. The purpose of the early review depends on the stage that the document has reached.

As this document is in working group last call, my focus for the review was to determine whether the document is ready to be published. Please consider my comments along with the other working group last call comments.

For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Document: draft-ietf-teas-yang-l3-te-topo-16.txt
Reviewer: Shuping Peng
Review Date: 28-Apr-2024
Intended Status: Standards

Summary:

I have some minor concerns about this document that I think should be resolved before it is submitted to the IESG.

Comments:

This document assumes that the TE topology model is already supported together with layer 3 unicast topology model in a network, right? What if the TE topology model is not supported? Can the layer 3 unicast topology model be directly extended to implement traffic engineering? For example, the IP network can obtain the L3 TE topology through BGP LS, which is much simpler. The TE topology model is more complex, including IP/MPLS network attributes and optical network attributes, and does not have the SR attributes. Could the description of this option of direct extension from layer 3 unicast topology model be also added in the document? 

As stated in Figure 3 and Section 2.2, YANG data type leafref is used to model the association relationship. Would the title be more accurate to be changed as "YANG Data Model for Layer 3 TE Topology References"?

Nits:

1. Section 2.2.1, in the last paragraph,
s/can still be used to specified TE parameters/can still be used to specify TE parameters