============== PATCH 1 CHANGES ========================= Below is a summary of changes that have taken place since Khoros 1.0 and this (first) patch. ~~~~~~~~~~~~~~~~~~~~~~~~~ VIPL LIBRARY ~~~~~~~~~~~~~~~~~~~~~~~~~ Routine : vtilt Fix/Modification : Had been coorrupted between Beta and 1.0 release without being documented. The FLOAT loop had a bogus pointer increment that was only hit when using a mask. Files Touched : $KHOROS_HOME/src/vipl/Lib/lvtilt.c --------------------- Routine : vgbox Fix/Modification : substituted XV_PI (convention) for PI (undefined on apollo) Files Touched : $KHOROS_HOME/src/vipl/input_create2D/vgbox/vgbox.c $KHOROS_HOME/src/vipl/input_create2D/vgbox/vgbox.h $KHOROS_HOME/src/vipl/input_create2D/vgbox/vgbox.prog $KHOROS_HOME/src/vipl/Lib/lvgbox.c Fix Provided By : Roque Oliveira (oliveria@caen.engin.umich.edu) --------------------- Routine : print_bit_image() / vpostscr Fix/Modification : The postscript output file added a pixel to both the rows and columns by not being able to count like a CS major by starting at 0. They went from 0 to rows instead of 0 to (rows - 1) and 0 to columns instead of 0 to (columns - 1). Files Touched : $KHOROS_HOME/src/vipl/Lib/lvpostscr.c Fix Provided By : John Salas --------------------- Routine : lvshrink() / vshrink Fix/Modification : The lvshrink routine was not properly shrinking bit images. The rows & cols were mixed up when computing the bytes per row. Files Touched : $KHOROS_HOME/src/vipl/Lib/lvshrink.c ~~~~~~~~~~~~~~~~~~~~~~~~~ VUTILS LIBRARY ~~~~~~~~~~~~~~~~~~~~~~~~~ Routine : readimage(), writeimage(), imgcache() Fix/Modification : Fixed a bug in the readimage/writimage/imgcache stuff so that "-" and "#" work correctly as filenames when the cache is enabled. Files Touched : $KHOROS_HOME/src/Lib/vutils/readimage.c $KHOROS_HOME/src/Lib/vutils/writeimage.c $KHOROS_HOME/src/Lib/vutils/imgcache.c --------------------- Routine : convert_raw_data() Fix/Modification : the parameter "type" did not have a declaration float *convert_raw_data(data, type, num_bytes, num_points, mach_type) Files Touched : $KHOROS_HOME/src/Lib/vutils/raw.c Fix Provided By : Bob Weaver (baw@inel.gov) ~~~~~~~~~~~~~~~~~~~~~~~~~ VGPARM LIBRARY ~~~~~~~~~~~~~~~~~~~~~~~~~ Routine : vfullpath() Fix/Modification : vfullpath() wouldn't correctly expand when called with vfullpath($ENV_VARIABLE, filename, NULL); Files Touched : $KHOROS_HOME/src/Lib/vgparm/fullpath.c ~~~~~~~~~~~~~~~~~~~~~~~~~ VMATH LIBRARY ~~~~~~~~~~~~~~~~~~~~~~~~~ Routine : cang() Fix/Modification : the declaration for atan2() was changed to first check if it was declared as a macro. Files Touched : $KHOROS_HOME/src/Lib/vmath/complex.c Fix Provided By : Bob Weaver (baw@inel.gov) --------------------- Routine : threshold() Fix/Modification : bug fixed involving the ml array overflowing; replaced static declaration with dynamic allocation Files Touched : $KHOROS_HOME/src/Lib/vmath/isef.c ~~~~~~~~~~~~~~~~~~~~~~~~~ XVFORMS LIBRARY ~~~~~~~~~~~~~~~~~~~~~~~~~ Routine : xvf_create_int_sel(), xvf_create_float_sel() Fix/Modification : calling sprintf assuming that the user only enters strings < 50 characters long. Some users are using very long expressions in saved cantata workspaces, so this was a problem. Files Touched : $KHOROS_HOME/src/xvroutines/Lib/createwid.c Fix Provided By : Mathew Yeates (mathew@elroy.jpl.nasa.gov) --------------------- Routine : xvf_clear_selections() Fix/Modification : the cycle widget was not being cleared Files Touched : $KHOROS_HOME/src/xvroutines/Lib/xvforms/form_util.c --------------------- Routine : various creation routines Fix/Modification : depth was not being set properly for GUI Files Touched : $KHOROS_HOME/src/xvroutines/Lib/xvforms/createform.c, $KHOROS_HOME/src/xvroutines/Lib/xvforms/createtree.c, $KHOROS_HOME/src/xvroutines/Lib/xvforms/manip.c, $KHOROS_HOME/src/xvroutines/Lib/xvforms/wid_util.c, --------------------- Routine : xvf_collect_xxx() Fix/Modification : ALL members of ME group incorrectly being marked as modified every time value of me group was changed causing incorrect behavior in cantata. Files Touched : $KHOROS_HOME/src/xvroutines/Lib/xvforms/collect.c --------------------- Routine : xvf_float_incr_scroll_cb(), xvf_float_incr_scroll_cb() Fix/Modification : fixed bug where movement of a float scroll bar caused XawTextReplace (incorrect argument end_pos) to overflow the buffer into our memory, since text was being appended in the middle, not added. Files Touched : $KHOROS_HOME/src/xvroutines/Lib/xvforms/callbacks.c --------------------- Routine : xvf_float_incr_scroll_cb(), xvf_int_incr_scroll_cb() Fix/Modification : fixed discrepancy where the amount of incremental movement of a (float or int) scroll bar was dependant on the size, and the jump over the range in question was fixed; it was pointed out that the opposite approach made more sense. Now, when you use the right or left mouse buttons to incrementally change the scroll bar, the pixel increment is fixed (12 pixels) and the range that that represents will vary according to the size of the scroll bar. Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvforms/callbacks.c $KHOROS_HOME/work/xvroutines/lib/xvforms/wid_util.c --------------------- Routine : xvf_get_scroll_incr() Fix/Modification : deleted this routine as it is no longer used (see above) Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvforms/form_util.c --------------------- Routine : xvf_initialize() Fix/Modification : fixed bug when, if KHOROS_VERBOSE was false, it would take the last choice of default font rather than the first (fixed). People were noticing this because their forms were all of a sudden very large & ugly for no apparent reason. Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvforms/init.c $KHOROS_HOME/work/xvroutines/lib/xvforms/form_util.c --------------------- Routine : xvf_initialize() Fix/Modification : pulled xvf_initialize() out of form_util.c, into init.c in an attempt to pacify a shared lib compile. Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvforms/init.c $KHOROS_HOME/work/xvroutines/lib/xvforms/Imakefile ~~~~~~~~~~~~~~~~~~~~~~~~~ XVDISPLAY LIBRARY ~~~~~~~~~~~~~~~~~~~~~~~~~ Routine : creation/update routines for XImage widget Fix/Modification : XImage widget was not properly refreshing when backing store was not available Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvdisplay/XImage.c --------------------- Routine : xvd_update_xcolors() Fix/Modification : added functionality to the xvd_update_xcolors() routine Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvdisplay/update.c --------------------- Routine : xvd_update_region() Fix/Modification : bug fixed involving for loop w/ incompatible variables (use of i and j when it should have been j only) Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvdisplay/update.c ~~~~~~~~~~~~~~~~~~~~~~~~~ FILE_FORMATS LIBRARY ~~~~~~~~~~~~~~~~~~~~~~~~~ Routine : lrast2viff() / rast2viff Fix/Modification : When the depth of the sunraster that was to be converted was one, the code did not do the conversion properly. 1. It was not putting the data into a (unsigned char) 2. It was not adjusting the pointer to the data under the the right conditions: width % 2 == 0 instead of width % 2 == 1 Files Touched : $KHOROS_HOME/src/file_formats/Lib/lrast2viff.c --------------------- Routine : lviff2pbm Fix/Modification : initialized "max_value" to 0; lack of initialization causing compile problems on apollo. Files Touched : $KHOROS_HOME/src/file_formats/lib/lviff2pbm.c $KHOROS_HOME/src/file_formats/standard/viff2pbm/viff2pbm.prog Fix Provided By : Roque Oliveira (oliveria@caen.engin.umich.edu) --------------------- Routine : lviff2viff Fix/Modification : fixed fprintf error message in VFF_TYP_BIT segment; attempting to print value that had not been set. Files Touched : $KHOROS_HOME/src/file_formats/lib/lviff2viff.c $KHOROS_HOME/src/file_formats/standard/viff2tiff/viff2tiff.prog Fix Provided By : Roque Oliveira (oliveria@caen.engin.umich.edu) --------------------- Routine : lvll2utm Fix/Modification : line 165: changed x_loc = (double) x_loc_ptr[index]; to x_loc = (double) x_loc_ptr[0]; and the same for y_loc -- index had not been initialized, causing problems on apollo. Files Touched : $KHOROS_HOME/src/file_formats/lib/lvll2utm.c $KHOROS_HOME/src/file_formats/remote_gis/viff2tiff/viff2tiff.prog Fix Provided By : Roque Oliveira (oliveria@caen.engin.umich.edu) ~~~~~~~~~~~~~~~~~~~~~~~~~ PUBLIC DOMAIN LIBRARIES ~~~~~~~~~~~~~~~~~~~~~~~~~ Library : linpack Fix/Modification : subroutine drot (n,dx,incx,dy,incy,c,s) was defined in two files: dblas.f and drot.f. We deleted it out of dblas.f, as suggested by Reiner. Files Touched : $KHOROS_HOME/src/public_domain/linpack/dblas.f Fix Provided By : Reiner Lenz (reiner@isy.liu.se) --------------------- Library : eispack Fix/Modification : routines were being re-defined all over the place. over-wrote all files with those provided by Reiner, so that no routine was defined more than once Files Touched : $KHOROS_HOME/src/public_domain/eispack/*.f Fix Provided By : Reiner Lenz (reiner@isy.liu.se) --------------------- Library : tiff library Fix/Modification : modified files in order to port public domain TIFF library to IBM RS6000. Files Touched : $KHOROS_HOME/src/public_domain/tiff/machdep.h $KHOROS_HOME/src/public_domain/tiff/tif_compat.c $KHOROS_HOME/src/public_domain/tiff/tif_dir.c $KHOROS_HOME/src/public_domain/tiff/tif_picio.c $KHOROS_HOME/src/public_domain/tiff/tif_print.c $KHOROS_HOME/include/file_formats/tiffcompat.h Fix Provided By : Bob Weaver (baw@inel.gov) ~~~~~~~~~~~~~~~~~~~~~~~~~ XVGRAPHICS LIBRARIES ~~~~~~~~~~~~~~~~~~~~~~~~~ Routine : X3D_set_line_width() Fix/Modification : changed the definitions of line widths so that they would actually change when you use X3D_set_line_width() on an X11 screen. Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvgraphics/X3D.h --------------------- Routine : X3D_rotate_coords(), X3D_translate_coords(), X3D_scale_coords(), X2D_rotate_coords(), X2D_translate_coords(), X2D_scale_coords() Fix/Modification : Incorrect in-lining of code caused incorrect results. Files Touched : $KHOROS_HOME/work/xvroutines/lib/xvgraphics/coord_2D.h $KHOROS_HOME/work/xvroutines/lib/xvgraphics/coord_3D.h ~~~~~~~~~~~~~~~~~~~~~~~~~ XPRISM2 & XPRISM3 ~~~~~~~~~~~~~~~~~~~~~~~~~ Fix/Modification : introduced global xp_device, that indicates which output device currently being written to. Then protected all calls to X3D_set_line_width() so they would not widen lines when we are writing to an X11 screen. Files Touched : $KHOROS_HOME/src/xvroutines/Lib/xvplot/axeslib.c $KHOROS_HOME/src/xvroutines/Lib/xvplot/box.c $KHOROS_HOME/src/xvroutines/Lib/xvplot/grid.c $KHOROS_HOME/src/xvroutines/Lib/xvplot/gwin_util.c $KHOROS_HOME/src/xvroutines/Lib/xvplot/plot_util.c $KHOROS_HOME/src/xvroutines/xprism2/axes2.c $KHOROS_HOME/src/xvroutines/xprism2/run_output.c $KHOROS_HOME/src/xvroutines/xprism3/axes3.c $KHOROS_HOME/src/xvroutines/xprism3/run_output.c $KHOROS_HOME/include/xprism.h --------------------- Fix/Modification : Previously, every time a new file is read in for xprism3 the number of rows had to be specified. Now, xprism3 remembers the last number of rows entered, and uses that as the default. Files Touched : $KHOROS_HOME/src/xvroutines/Lib/xvplot/input.c ~~~~~~~~~~~~~~~~~~~~~~~~~ VIEWIMAGE ~~~~~~~~~~~~~~~~~~~~~~~~~ Fix/Modification : substituted mathematical version of rint() call, as rint() is not part of HP-UX (reported by kk) Files Touched : $KHOROS_HOME/src/xvroutines/viewimage/create_util.c Fix Provided By : Konstantinos Konstantinides (kk@hpkronos.hpl.hp.com) ~~~~~~~~~~~~~~~~~~~~~~~~~ EDITIMAGE ~~~~~~~~~~~~~~~~~~~~~~~~~ Fix/Modification : changed ROI commands to reflect the new xprism3 command line: { " xprism3 ", "xprism3", "-i11", NULL, " " }, Files Touched : $KHOROS_HOME/src/xvroutines/editimage/roi.h --------------------- Fix/Modification : Two of the automatic colormap features (HLS & HSV RINGS) would core dump when trying to autocolor binary BYTE (2-tone) images (wolf.xv being the image in question). Files Touched : $KHOROS_HOME/src/xvroutines/lib/xvdisplay/autocolor.c ~~~~~~~~~~~~~~~~~~~~~~~~~ CANTATA ~~~~~~~~~~~~~~~~~~~~~~~~~ Fix/Modification : fixed the problem where cantata would fail/seg fault/ core dump/ freak out when saving a compressed workspace on a SUN4 architecture. Files Touched : $KHOROS_HOME/src/xvroutines/lib/xvforms/system.c ------------------------ Enhancement : Three new control glyphs were added to cantata. They are a switch, expression, and trigger glyph. These control glyph routines were kindly donated by: Mathew Yeates (mathew@elroy.jpl.nasa.gov) Note: due to lack of time the online documentation was not properly updated for these new glyphs. The next patch will contain a more complete description of the functionality and use of these new glyphs Files Touched : $KHOROS_HOME/src/xvroutines/cantata/control.c $KHOROS_HOME/src/xvroutines/cantata/run.c $KHOROS_HOME/src/xvroutines/cantata/check.c $KHOROS_HOME/repos/cantata/control/expr.pane $KHOROS_HOME/repos/cantata/control/switch.pane $KHOROS_HOME/repos/cantata/control/trigger.pane $KHOROS_HOME/doc/cantata/control/expression $KHOROS_HOME/doc/cantata/control/switch $KHOROS_HOME/doc/cantata/control/trigger Provided By : Mathew Yeates ~~~~~~~~~~~~~~~~~~~~~~~~~ GHOSTWRITER ~~~~~~~~~~~~~~~~~~~~~~~~~ Fix/Modification : modified to include correct Khoros RCS headers in generated *.c, l*.c, and *.h files Files Touched : $KHOROS_HOME/src/xvroutines/writer/gw_lib.c $KHOROS_HOME/src/xvroutines/writer/gw_main.c $KHOROS_HOME/src/xvroutines/writer/gw_struct.c ------------------------ Fix/Modification : modified so that the ONLY time that "imkmf" and "makemake" are called is when there is NO Imakefile in the current directory; users are expected to run imkmf & makemake when necessary, on their own. Files Touched : $KHOROS_HOME/src/xvroutines/writer/lwriter.c ~~~~~~~~~~~~~~~~~~~~~~~~~ CONDUCTOR ~~~~~~~~~~~~~~~~~~~~~~~~~ Fix/Modification : modified to include correct Khoros RCS headers in generated *.c, and *.h files Files Touched : $KHOROS_HOME/src/xvroutines/conductor/cnd_drv.c $KHOROS_HOME/src/xvroutines/conductor/cnd_incl.c $KHOROS_HOME/src/xvroutines/conductor/cnd_info.c $KHOROS_HOME/src/xvroutines/conductor/cnd_init.c ~~~~~~~~~~~~~~~~~~~~~~~~~ CONFIGURATION FILES ~~~~~~~~~~~~~~~~~~~~~~~~~ What : Shared Sun Libraries Fix/Modification : changed imake configuration files to fix several compile problems. Files Touched : $KHOROS_HOME/repos/config/imake_conf/sun.cf $KHOROS_HOME/repos/config/imake_conf/Khoros.tmpl $KHOROS_HOME/repos/config/imake_tmpls/Lib.template Fix Provided By : Many Many helpful people, but especially Reiner Lenz (reiner@isy.liu.se) Steven S. Dick (ssd@engr.ucf.edu) and Dan (dan@hao.ucar.edu) --------------------- What : apollo configuration file Fix/Modification : changed #define HasVoidSignalReturn YES to #define HasVoidSignalReturn NO Files Touched : $KHOROS_HOME/repos/config/imake_conf/apollo.cf Fix Provided By : Roque Oliveira (oliveria@caen.engin.umich.edu) --------------------- What : ibm configuration file Fix/Modification : many many many changes... the original configuration file was bogus since we don't have an IBM. Bob Weaver at Idaho National Labs ported Khoros and gave us his changes Files Touched : $KHOROS_HOME/repos/config/imake_conf/ibm.cf $KHOROS_HOME/repos/config/imake_conf/Khoros.tmpl Fix Provided By : Bob Weaver (baw@inel.gov) --------------------- What : sgi configuration file Fix/Modification : changed the DefaultCCOptions to include -Wl,-s Files Touched : $KHOROS_HOME/repos/config/imake_conf/sgi.cf Fix Provided By : Bob Weaver (baw@inel.gov) --------------------- What : sgi configuration file Fix/Modification : changed the the DefaultCCOptions to not include -float option. This was causing many strange warnings while compiling. Files Touched : $KHOROS_HOME/repos/config/imake_conf/sgi.cf --------------------- What : sgi configuration file Fix/Modification : changed the the InstallCmd to use the $(SCRIPTSRC)/install.sh instead of the $(SCRIPTSRC)/bsdinst.sh Files Touched : $KHOROS_HOME/repos/config/imake_conf/sgi.cf --------------------- What : hp configuration file Fix/Modification : Changed minor/major version numbers, changed HasFortran No to HasFortran Yes Files Touched : $KHOROS_HOME/repos/config/imake_conf/hp.cf Fix Provided By : Konstantinos Konstantinides (kk@hplvis2.hpl.hp.com) ~~~~~~~~~~~~~~~~~~~~~~~~~ TOOLS ~~~~~~~~~~~~~~~~~~~~~~~~~ Program : imake Fix/Modification : added support for IBM RS-6000 Files Touched : $KHOROS_HOME/bootstrap/imake/imakemdep.h Fix Provided By : Bob Weaver (baw@inel.gov) --------------------- Program : installit Fix/Modification : added /usr/lang to the search path, added message about bootstrapping for IBM RS-6000, and changed the install program to clean makedepend before making. Files Touched : $KHOROS_HOME/src/installit Fix Provided By : Bob Weaver (baw@inel.gov) --------------------- Program : prnmanual Fix/Modification : 1) STDOUT_FLAG use a full flag "-p" instead of just "p" 2) Added file extension so that non-postscript formatters wouldn't with a file.ps (.ps) extension 3) Added the printer destination name flag PTRNAME_FLAG since not all unix boxes use -P{printer name} 4) Added default print command so that the user doesn't have to change the "lpr" command every time. Files Touched : $KHOROS_HOME/src/scripts/prnmanual/prnmanual.csh Fix Provided By : Konstantinos Konstantinides (kk@hplvis2.hpl.hp.com) --------------------- ~~~~~~~~~~~~~~~~~~~~~~~~~ MISCELLANEOUS ~~~~~~~~~~~~~~~~~~~~~~~~~ What : $KHOROS_CONTRIB/src/xvroutines Fix/Modification : imkmf on Imakefile to include example2 Files Touched : $KHOROS_CONTRIB/src/xvroutines/Imakefile --------------------- What : Bug Report form Fix/Modification : Took out decorative "~ ~ ~" since it interfered with mail when you used cat. Files Touched : $KHOROS_HOME/repos/BugReport --------------------- What : whatis Fix/Modification : incorrect inclusion of "check" and "reader"; substituted "ghostcheck" and "ghostreader". typo for mlse(1). Files Touched : $KHOROS_HOME/man/whatis Fix Provided By : Roque Oliveira (oliveria@caen.engin.umich.edu) --------------------- What : intro1 Fix/Modification : incorrect inclusion of "reader"; substituted "ghostreader". typo for mlse(1). Files Touched : $KHOROS_HOME/man/man1/intro.1 Fix Provided By : Roque Oliveira (oliveria@caen.engin.umich.edu) --------------------- What : man pages Fix/Modification : removed symbolic link from ghostcheck.1 to check.1. moved check.1 to ghostcheck.1; fixed typo in mlse.1. Files Touched : $KHOROS_HOME/man/man1/ghostcheck.1 $KHOROS_HOME/man/man1/mlse.1 Fix Provided By : Roque Oliveira (oliveria@caen.engin.umich.edu) --------------------- What : general include files changed Fix/Modification : modified include files in order to port Khoros to an IBM RS6000 and SGI. Files Touched : $KHOROS_HOME/include/vinclude.h $KHOROS_HOME/include/vdefines.h $KHOROS_HOME/include/vsignal.h $KHOROS_HOME/include/xvinclude.h Fix Provided By : Bob Weaver (baw@inel.gov) --------------------- What : corrected journal playback README with respect to warpimage Fix/Modification : changed line 40 was: warpimage -jp warpimage is: warpimage -jp $KHOROS_HOME/repos/journals/warpimage.jp Files Touched : $KHOROS_HOME/repos/journals/README Fix Provided By : Steven Kubica ---------------------